Fix website accessibility (MAS/WCAG) issues from Accessibility Insights FastPass#840
Closed
MaanavD wants to merge 2 commits into
Closed
Fix website accessibility (MAS/WCAG) issues from Accessibility Insights FastPass#840MaanavD wants to merge 2 commits into
MaanavD wants to merge 2 commits into
Conversation
…sights Resolves axe-core/FastPass findings on the marketing site: - heading-order (WCAG 1.3.1): promote the 'Start with the SDK' card heading from h3 to h2 so the hero h1 is followed by an h2. - image-redundant-alt: the nav logo image duplicated the adjacent 'Foundry Local' text label; mark the image decorative (alt=\\) since the visible text already names it. - page-has-heading-one: add an sr-only h1 to the /models page and set the 'Browse Foundry Models' filter card title to aria-level 2, giving a valid h1 -> h2 -> h3 outline. Verified with axe-core (wcag2a/aa, wcag21a/aa, best-practice): 0 violations on home (light+dark) and /models, down from the findings above. No new svelte-check errors (17 pre-existing baseline unchanged). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@MaanavD is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes accessibility (MAS/WCAG) issues on the Foundry Local marketing website (www/) that were surfaced by Accessibility Insights FastPass (axe-core). It addresses three axe rules — heading-order, image-redundant-alt, and page-has-heading-one — across the Home and Models pages, all via small, semantic markup adjustments without behavioral changes.
Changes:
- Promote the "Start with the SDK" card heading from
<h3>to<h2>so the Home page no longer skips a heading level under the hero<h1>. - Mark the nav logo image decorative (
alt="") to avoid screen readers announcing "Foundry Local" twice (image + adjacent text label). - Give the
/modelspage a valid heading outline by adding ansr-only<h1>and setting the filter card title toaria-level={2}.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
www/src/lib/components/install-command.svelte |
Changes the SDK card heading from <h3> to <h2> to fix heading-order under the hero <h1>. |
www/src/lib/components/home/nav.svelte |
Sets the logo alt="" to mark it decorative, resolving image-redundant-alt. |
www/src/routes/models/+page.svelte |
Adds an sr-only <h1> so the Models page satisfies page-has-heading-one. |
www/src/routes/models/components/ModelFilters.svelte |
Sets the filter card title to level={2} to complete a valid h1→h2→h3 outline. |
Creates a no-op commit to request a fresh Vercel deployment for PR microsoft#840 without changing source content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Replaced by #841, which uses an upstream branch instead of a fork branch so Vercel can deploy without the fork authorization gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the accessibility (Microsoft Accessibility Standards / WCAG) issues on the Foundry Local marketing website surfaced by Accessibility Insights FastPass (axe-core automated checks). This is the code-actionable portion of the June 2026 SDL Accessibility attestation (ADO User Story 97169 → Task 97172 "Run Accessibility Insights & Fix Bugs").
Findings & fixes
heading-order<h3>directly under the hero<h1>, skipping<h2>. Promoted to<h2>.image-redundant-alt<img>hadalt="Foundry Local"immediately next to a visible "Foundry Local" text label, so screen readers announced it twice. Marked the image decorative (alt=""); the adjacent text already provides the accessible name.page-has-heading-one/modelspage had no<h1>. Added ansr-only<h1>and set the "Browse Foundry Models" filter card title toaria-level={2}, producing a validh1 → h2 → h3outline.Verification
Ran axe-core (tags:
wcag2a,wcag2aa,wcag21a,wcag21aa,best-practice) against the running dev site:heading-order+image-redundant-alt)image-redundant-alt+page-has-heading-one); heading outline nowL1 → L2 → L3npm run check(svelte-check) holds at the pre-existing 17-error baseline — these changes introduce no new type errors. (The repo is not currently Prettier-formatted; untouched files report the same Prettier warnings, so that's a pre-existing condition and out of scope here.)Notes for the broader attestation
This PR closes the automated-scan ("Accessibility 2") portion. The remaining ADO tasks are process steps that require a human: requesting the Trusted Tester test pass (Accessibility 3), fixing any A11yMAS bugs they file (Accessibility 4), and publishing conformance documentation (Accessibility 5).
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com