Skip to content

Bump Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 to 18.7.23 #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −12
Open

Bump Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 to 18.7.23 #2897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5d2a43
Bump Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 to 18.7.23
dependabot[bot] Jun 22, 2026
bb81128
fix(library): avoid synchronous crypto finalization
Copilot Jun 23, 2026
1bb4c6f
perf(library): avoid hash buffer copy
Copilot Jun 23, 2026
26dec1b
fix(library): hash only written buffer bytes
Copilot Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi.Hidi/Microsoft.OpenApi.Hidi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="10.0.9" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi.YamlReader/Microsoft.OpenApi.YamlReader.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi/Microsoft.OpenApi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
13 changes: 4 additions & 9 deletions src/Microsoft.OpenApi/Models/OpenApiDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,25 +566,20 @@ public void SetReferenceHostDocument()
/// <returns>The hash value.</returns>
public async Task<string> GetHashCodeAsync(CancellationToken cancellationToken = default)
{
#if NET7_OR_GREATER
using var memoryStream = new MemoryStream();
using var streamWriter = new StreamWriter(memoryStream);

await WriteDocumentAsync(streamWriter, cancellationToken).ConfigureAwait(false);

#if NET7_OR_GREATER
memoryStream.Seek(0, SeekOrigin.Begin);

var hash = await SHA512.HashDataAsync(memoryStream, cancellationToken).ConfigureAwait(false);
#else
using HashAlgorithm sha = SHA512.Create();
using var cryptoStream = new CryptoStream(Stream.Null, sha, CryptoStreamMode.Write);
using var streamWriter = new StreamWriter(cryptoStream);

await WriteDocumentAsync(streamWriter, cancellationToken).ConfigureAwait(false);

cryptoStream.FlushFinalBlock();

var hash = sha.Hash;
var hash = memoryStream.TryGetBuffer(out ArraySegment<byte> buffer) && buffer.Array is byte[] array
? sha.ComputeHash(array, buffer.Offset, buffer.Count)
: sha.ComputeHash(memoryStream.ToArray());
#endif

return ConvertByteArrayToString(hash ?? []);
Expand Down