Skip to content

Surface per-batch record count (param2) in HTTP response debug events #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mogiligarimidi23 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Surface per-batch record count (param2) in HTTP response debug events #1487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/http/HttpResponseDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ namespace MAT_NS_BEGIN {
DebugEvent evt;
evt.type = DebugEventType::EVT_HTTP_OK;
evt.param1 = response.GetStatusCode();
evt.param2 = ctx->recordIdsAndTenantIds.size();
evt.data = static_cast<void *>(request.GetBody().data());
evt.size = request.GetBody().size();
DispatchEvent(evt);
Expand All @@ -112,6 +113,7 @@ namespace MAT_NS_BEGIN {
// This is to be addressed with ETW trace API that can send
// a detailed error context to ETW provider.
evt.param1 = response.GetStatusCode();
evt.param2 = ctx->recordIdsAndTenantIds.size();
evt.data = static_cast<void *>(request.GetBody().data());
evt.size = request.GetBody().size();
DispatchEvent(evt);
Expand All @@ -127,6 +129,7 @@ namespace MAT_NS_BEGIN {
DebugEvent evt;
evt.type = DebugEventType::EVT_HTTP_FAILURE;
evt.param1 = 0; // response.GetStatusCode();
evt.param2 = ctx->recordIdsAndTenantIds.size();
DispatchEvent(evt);
}
ctx->httpResponse = nullptr;
Expand All @@ -144,6 +147,7 @@ namespace MAT_NS_BEGIN {
DebugEvent evt;
evt.type = DebugEventType::EVT_HTTP_FAILURE;
evt.param1 = response.GetStatusCode();
evt.param2 = ctx->recordIdsAndTenantIds.size();
DispatchEvent(evt);
}
temporaryServerFailure(ctx);
Expand All @@ -157,6 +161,7 @@ namespace MAT_NS_BEGIN {
DebugEvent evt;
evt.type = DebugEventType::EVT_HTTP_FAILURE;
evt.param1 = response.GetStatusCode();
evt.param2 = ctx->recordIdsAndTenantIds.size();
DispatchEvent(evt);
}
temporaryNetworkFailure(ctx);
Expand Down Expand Up @@ -253,4 +258,3 @@ namespace MAT_NS_BEGIN {
}

} MAT_NS_END

Loading