Skip to content

gcs-sidecar/bridge: Do not enforce MaxMsgSize on incoming messages #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micromaomao wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

gcs-sidecar/bridge: Do not enforce MaxMsgSize on incoming messages #2786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/gcs-sidecar/bridge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ func readMessage(r io.Reader) (messageHeader, []byte, error) {
}

n := header.Size
if n < prot.HdrSize || n > prot.MaxMsgSize {

@anmaxvl anmaxvl Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inbox GCS transport has a buffer limit of 64kb, so maybe we can drop this check for messages handled strictly by gcs-sidecar (policy/fragments etc) and we can ensure the size on the rest of the messages?

// Deliberately don't enforce MaxMsgSize here. This follows what the LCOW
// gcs does, and allows us to inject long fragments.
if n < prot.HdrSize {
logrus.Errorf("invalid message size %d", n)
return messageHeader{}, nil, fmt.Errorf("invalid message size %d: %w", n, err)
}
Expand Down
Loading