Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/wclayer/legacy.go
Original file line number Diff line number Diff line change
Expand Up @@ -453,15 +453,15 @@ func (w *legacyLayerWriter) reset() (err error) {
w.currentFile = nil
w.currentFileName = ""
w.currentFileRoot = nil
w.currentIsDir = false
}
w.currentIsDir = false
}()

if err = w.bufWriter.Flush(); err != nil {
return err
}
w.bufWriter.Reset(io.Discard)
if w.currentIsDir {
if w.currentIsDir && w.currentFile != nil {
r := w.currentFile
br := winio.NewBackupStreamReader(r)
// Seek to the beginning of the backup stream, skipping the fileattrs
Expand Down
17 changes: 17 additions & 0 deletions internal/wclayer/legacy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,23 @@ func Test_legacyLayerWriter_reset_ClearsCurrentIsDirOnError(t *testing.T) {
}
}

// Test_legacyLayerWriter_reset_DirFlagWithoutFile verifies reset is robust when
// currentIsDir is true but currentFile is nil (a state that can occur if an
// earlier error path closed/cleared currentFile before currentIsDir was reset).
func Test_legacyLayerWriter_reset_DirFlagWithoutFile(t *testing.T) {
w := &legacyLayerWriter{
currentIsDir: true,
bufWriter: bufio.NewWriter(io.Discard),
}

if err := w.reset(); err != nil {
t.Fatalf("expected reset to succeed when currentFile is nil, got: %v", err)
}
if w.currentIsDir {
t.Error("expected currentIsDir to be false after reset")
}
}

// closes and clears the current file handle.
func Test_legacyLayerWriter_reset_ClosesFileOnSuccess(t *testing.T) {
dir := t.TempDir()
Expand Down
Loading