No hermes explicit microtasks in paper#16249
Open
acoates-ms wants to merge 2 commits into
Open
Conversation
acoates-ms
changed the title
vmoroz
approved these changes
Jun 11, 2026
tido64
reviewed
Jun 12, 2026
| }; | ||
|
|
||
| devSettings->useWebSocketTurboModule = getBoolProperty(nullptr, L"UseWebSocketTurboModule", false); | ||
| devSettings->hermesSetExplicitMicrotasks = false; |
Member
There was a problem hiding this comment.
Why is this enabled here? Wouldn't paper always want this off?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The legacy paper renderer is not setup to explicitly drain microtasks. But we are always configuring hermes into explicit microtask mode. In core this is controlled by facebook::react::ReactNativeFeatureFlags::enableBridgelessArchitecture(). But that is a global setting, not a per instance setting, which is what we need for Office.
Instead we set a property on the devSettings object to control if we should use explicit microtasks or not.
This fixes an issue where in some cases await calls would not get flushed until another message came though the queue. Which would cause the app to appear hung, and then unfreeze on a mouse move.
Microsoft Reviewers: Open in CodeFlow