Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the previously removed windows-rs “feature search” by adding a metadata-driven generator that produces a self-contained static search page under web/features, and wiring up CI to keep it regenerated and deploy it via GitHub Pages (addressing #4631).
Changes:
- Add
tool_featuresto generateweb/features/index.htmlfrom the bundled.winmdmetadata, including extra required features inferred from function/method signatures. - Add a GitHub Pages workflow to deploy the
web/folder (serving the page at/features). - Extend the
genworkflow matrix to include the newfeaturestool so generated output stays up to date.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/tools/features/src/main.rs | Implements the metadata scan and emits a dependency-free, inlined-index web/features/index.html. |
| crates/tools/features/Cargo.toml | Adds the new tool_features crate configuration and dependency on windows-metadata. |
| .github/workflows/web.yml | Deploys ./web to GitHub Pages on updates, enabling the /features endpoint. |
| .github/workflows/gen.yml | Adds features to the tool generation matrix so CI verifies the generated page is current. |
tim-weis
reviewed
Jun 25, 2026
| if (own) features.push(own); | ||
| if (extras) for (const ei of extras) { const f = featureOf(DATA.namespaces[ei]); if (f) features.push(f); } | ||
| const cell = features.length | ||
| ? features.map(f => '<code class="feature">' + f + '</code>').join(' + ') |
Contributor
There was a problem hiding this comment.
Can this be changed to render features enclosed in ASCII double quotes ("), concatenated by , instead of +? This would enable copy-pasting the output straight into Cargo.toml, just like the previous feature search did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4631