Merge Dev#249
Open
arjunsuresh wants to merge 17 commits into
Open
Conversation
Update README.md | fix badge urls
Rename mlcflow_linux.sh to mlcflow_unix_installer.sh
Add item creation function to handle invalid meta entries in index
Update mlcflow_unix_installer.sh | avoid --checkout when not needed
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by conditionally adding the branch checkout argument only if specified, preventing potential errors. Additionally, the Action class in mlc/action.py is refactored to safely handle index entries with invalid metadata by skipping them and logging a warning, improving robustness. The version is bumped from 1.2.3 to 1.2.4. Risks are low but include potential breakage if any references to the old installer script name are missed. The design improvements enhance error handling and script flexibility. |
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by making the branch checkout optional in the pull_repo function. Additionally, the Action class in mlc/action.py is refactored to handle invalid meta data gracefully by skipping such items, improving robustness. The README badges are updated to point to the dev branch, and the version is bumped from 1.2.3 to 1.2.4. Overall, the changes are low risk but require careful validation of the installer script URL updates and the new optional branch logic to avoid breaking installs or CI workflows. |
#250) * Add tests for checking invalid meta entries in action search * Cleanup docstring in unit test
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the CI workflows accordingly. It adds a new GitHub Actions workflow for unit tests running on Python 3.8 and 3.14. The Action class is enhanced to skip items with invalid or missing meta data during search operations, improving robustness. A new test suite is added to verify that invalid meta entries are properly skipped. Minor improvements in the installer script handle optional branch checkout more safely. The version is bumped to 1.2.4 and README badges are updated to point to the dev branch. Overall, the changes improve test coverage and robustness with minimal risk, but the installer rename requires coordinated updates in user documentation and deployment scripts to avoid breakage. |
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references accordingly in the CI workflows and documentation. It adds a new GitHub Actions workflow for running unit tests on multiple Python versions. The Action class is enhanced to skip items with invalid metadata during search operations, improving robustness. A new test suite is added to verify that invalid meta entries are correctly skipped. The installer script pull_repo function is improved to handle optional branch checkout more safely. The version is bumped to 1.2.4. Risks include potential breakage if any references to the old installer script remain or if the new meta validation logic incorrectly excludes valid items. The design improves reliability and test coverage but requires careful validation of installer script renaming and meta handling. |
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflows accordingly. It adds a new GitHub Actions workflow for running unit tests on multiple Python versions. The indexing logic in mlc/index.py is improved to validate script meta files during indexing, raising errors on invalid meta. The Action class in mlc/action.py is enhanced to skip items with invalid meta when searching or fetching items. The installer script pull_repo function is updated to conditionally include the branch checkout argument. The README badges are updated to point to the dev branch. The version is bumped from 1.2.3 to 1.2.4. Overall, the changes improve robustness by validating meta files early and add unit test coverage. Risks include potential CI failures if meta validation is too strict or if the new installer script has issues. The design is sound but the meta validation error raising in indexing may block indexing if meta is invalid, which should be carefully tested. |
🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the CI workflows accordingly, reducing platform specificity. It adds a new GitHub Actions workflow for unit tests running on Python 3.8 and 3.14. The installer script pull_repo function is improved to handle optional branch checkout more robustly. The Action class is enhanced to skip items with invalid meta during indexing and searching, improving stability. The Index class now validates script meta during indexing and raises errors on validation failure, centralizing validation logic. A new test suite is added to verify handling of invalid meta entries. The README badges are updated to point to the dev branch. The version is bumped to 1.2.4. Overall, the changes improve robustness and test coverage but introduce risk of CI failures if meta validation errors occur or if the new installer script is not backward compatible. The design is sound but requires careful validation of meta files and installer script correctness. |
🤖 AI PR Review Summary\n\nThis PR introduces new unit tests for error guidance handling, renames and updates the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh with safer branch handling, adds a new GitHub Actions workflow for unit tests across multiple Python versions, and updates existing workflows and README badges to reflect the new installer script and branch references. It also improves the Action class by filtering out items with invalid metadata and enhances error code handling. Risks include potential breakage if the renamed installer script is not properly propagated or if the new meta validation filters out valid items incorrectly. Design is generally sound with improved test coverage and safer script execution. |
🤖 AI PR Review Summary\n\nThis PR adds a new test script for error guidance handling, integrates it into the core actions CI workflow, introduces a new unit test workflow for Python versions 3.8 and 3.14, renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh with corresponding updates in the CI workflows and README badges, and improves robustness in the Action class by skipping items with invalid metadata. The main risks involve potential CI failures if the new test script or renamed installer script paths are incorrect, and the design improvement in Action class enhances stability by avoiding invalid meta entries. The installer script change adds conditional handling for branch checkout, improving flexibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.✅ Testing & CI
📚 Documentation
📁 File Hygiene & Output Handling
🛡️ Safety & Security
🙌 Contribution Hygiene
Fixes #orCloses #.