Skip to content

Merge Dev#249

Open
arjunsuresh wants to merge 17 commits into
mainfrom
dev
Open

Merge Dev#249
arjunsuresh wants to merge 17 commits into
mainfrom
dev

Conversation

@arjunsuresh

Copy link
Copy Markdown
Contributor

✅ PR Checklist

  • Target branch is dev

📌 Note: PRs must be raised against dev. Do not commit directly to main.

✅ Testing & CI

  • Have tested the changes in my local environment, else have properly conveyed in the PR description
  • The change includes a GitHub Action to test the script(if it is possible to be added).
  • No existing GitHub Actions are failing because of this change.

📚 Documentation

  • README or help docs are updated for new features or changes.
  • CLI help messages are meaningful and complete.

📁 File Hygiene & Output Handling

  • No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed.

🛡️ Safety & Security

  • No secrets or credentials are committed.
  • Paths, shell commands, and environment handling are safe and portable.

🙌 Contribution Hygiene

  • PR title and description are concise and clearly state the purpose of the change.
  • Related issues (if any) are properly referenced using Fixes # or Closes #.
  • All reviewer feedback has been addressed.

@arjunsuresh arjunsuresh requested a review from a team as a code owner June 13, 2026 12:09
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by conditionally adding the branch checkout argument only if specified, preventing potential errors. Additionally, the Action class in mlc/action.py is refactored to safely handle index entries with invalid metadata by skipping them and logging a warning, improving robustness. The version is bumped from 1.2.3 to 1.2.4. Risks are low but include potential breakage if any references to the old installer script name are missed. The design improvements enhance error handling and script flexibility.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflow and documentation accordingly. It also improves the installer script by making the branch checkout optional in the pull_repo function. Additionally, the Action class in mlc/action.py is refactored to handle invalid meta data gracefully by skipping such items, improving robustness. The README badges are updated to point to the dev branch, and the version is bumped from 1.2.3 to 1.2.4. Overall, the changes are low risk but require careful validation of the installer script URL updates and the new optional branch logic to avoid breaking installs or CI workflows.

sujik18 and others added 2 commits June 20, 2026 19:06
#250)

* Add tests for checking invalid meta entries in action search

* Cleanup docstring in unit test
@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the CI workflows accordingly. It adds a new GitHub Actions workflow for unit tests running on Python 3.8 and 3.14. The Action class is enhanced to skip items with invalid or missing meta data during search operations, improving robustness. A new test suite is added to verify that invalid meta entries are properly skipped. Minor improvements in the installer script handle optional branch checkout more safely. The version is bumped to 1.2.4 and README badges are updated to point to the dev branch. Overall, the changes improve test coverage and robustness with minimal risk, but the installer rename requires coordinated updates in user documentation and deployment scripts to avoid breakage.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references accordingly in the CI workflows and documentation. It adds a new GitHub Actions workflow for running unit tests on multiple Python versions. The Action class is enhanced to skip items with invalid metadata during search operations, improving robustness. A new test suite is added to verify that invalid meta entries are correctly skipped. The installer script pull_repo function is improved to handle optional branch checkout more safely. The version is bumped to 1.2.4. Risks include potential breakage if any references to the old installer script remain or if the new meta validation logic incorrectly excludes valid items. The design improves reliability and test coverage but requires careful validation of installer script renaming and meta handling.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the GitHub workflows accordingly. It adds a new GitHub Actions workflow for running unit tests on multiple Python versions. The indexing logic in mlc/index.py is improved to validate script meta files during indexing, raising errors on invalid meta. The Action class in mlc/action.py is enhanced to skip items with invalid meta when searching or fetching items. The installer script pull_repo function is updated to conditionally include the branch checkout argument. The README badges are updated to point to the dev branch. The version is bumped from 1.2.3 to 1.2.4. Overall, the changes improve robustness by validating meta files early and add unit test coverage. Risks include potential CI failures if meta validation is too strict or if the new installer script has issues. The design is sound but the meta validation error raising in indexing may block indexing if meta is invalid, which should be carefully tested.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh and updates all references in the CI workflows accordingly, reducing platform specificity. It adds a new GitHub Actions workflow for unit tests running on Python 3.8 and 3.14. The installer script pull_repo function is improved to handle optional branch checkout more robustly. The Action class is enhanced to skip items with invalid meta during indexing and searching, improving stability. The Index class now validates script meta during indexing and raises errors on validation failure, centralizing validation logic. A new test suite is added to verify handling of invalid meta entries. The README badges are updated to point to the dev branch. The version is bumped to 1.2.4. Overall, the changes improve robustness and test coverage but introduce risk of CI failures if meta validation errors occur or if the new installer script is not backward compatible. The design is sound but requires careful validation of meta files and installer script correctness.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR introduces new unit tests for error guidance handling, renames and updates the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh with safer branch handling, adds a new GitHub Actions workflow for unit tests across multiple Python versions, and updates existing workflows and README badges to reflect the new installer script and branch references. It also improves the Action class by filtering out items with invalid metadata and enhances error code handling. Risks include potential breakage if the renamed installer script is not properly propagated or if the new meta validation filters out valid items incorrectly. Design is generally sound with improved test coverage and safer script execution.

@github-actions

Copy link
Copy Markdown

🤖 AI PR Review Summary\n\nThis PR adds a new test script for error guidance handling, integrates it into the core actions CI workflow, introduces a new unit test workflow for Python versions 3.8 and 3.14, renames the installer script from mlcflow_linux.sh to mlcflow_unix_installer.sh with corresponding updates in the CI workflows and README badges, and improves robustness in the Action class by skipping items with invalid metadata. The main risks involve potential CI failures if the new test script or renamed installer script paths are incorrect, and the design improvement in Action class enhances stability by avoiding invalid meta entries. The installer script change adds conditional handling for branch checkout, improving flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants