Carry a configured fee claim into register_node#38
Merged
Conversation
Mirror of the same change on the variant branch, applied here to the plain lsp-0.7.0 branch so the two ldk-node lines stay identical. The only difference is the rust-lightning pin: this branch tracks the plain lsp-0.2.0 lineage, so it moves aad7c226 -> bdcdf57de (M1+M2+A1) rather than the variant rev. Both tips now carry the fee-claim field, the verifier, and the new register_node parameter. The bump forces three coupled changes, so they land together. Client side: LSPS4ClientConfig and the internal LSPS4Client now hold an optional fee_claim, set_liquidity_source_lsps4 takes it as a third argument, and lsps4_register_node relays it on every registration. The value is opaque here, a lowercase-hex signed grant that only the LSP decodes. Service side: the bumped LdkLSPS4ServiceConfig grew an issuer_pubkeys field with no Default, so the struct literal no longer compiles without naming it. LSPS4ServiceConfig surfaces it. This is the field the LSP role on this branch actually uses; mdkd's integration test stands up an in-process LSP from it and seeds the test-vector issuer key. An empty Vec honours no claim and keeps every peer on the standard policy. With no claim configured the request carries None, the LSP resolves the standard policy, and behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of the same change on the variant branch, applied here to the plain lsp-0.7.0 branch so the two ldk-node lines stay identical. The only difference is the rust-lightning pin: this branch tracks the plain lsp-0.2.0 lineage, so it moves aad7c226 -> bdcdf57de (M1+M2+A1) rather than the variant rev. Both tips now carry the fee-claim field, the verifier, and the new register_node parameter.
The bump forces three coupled changes, so they land together.
Client side: LSPS4ClientConfig and the internal LSPS4Client now hold an optional fee_claim, set_liquidity_source_lsps4 takes it as a third argument, and lsps4_register_node relays it on every registration. The value is opaque here, a lowercase-hex signed grant that only the LSP decodes.
Service side: the bumped LdkLSPS4ServiceConfig grew an issuer_pubkeys field with no Default, so the struct literal no longer compiles without naming it. LSPS4ServiceConfig surfaces it. This is the field the LSP role on this branch actually uses; mdkd's integration test stands up an in-process LSP from it and seeds the test-vector issuer key. An empty Vec honours no claim and keeps every peer on the standard policy.
With no claim configured the request carries None, the LSP resolves the standard policy, and behaviour is unchanged.