Add @covers annotations to the service-wiring tests#102
Merged
Conversation
The three service-wiring construction tests lacked @Covers annotations, so MediaWiki's generated PHPUnit config (which sets forceCoversAnnotation) flagged them as risky. Annotate each test method with the class it exercises through the extension's service wiring: BootstrapComponentsService, ComponentLibrary, and NestingController. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MediaWiki's generated PHPUnit configuration sets
forceCoversAnnotation, so any test without a@coversannotation is reported as risky. On the 1.46/master CI rows, three tests intests/phpunit/Unit/ServiceWiringTest.phpwere flagged risky for this reason:testCanConstructBootstrapComponentsServicetestCanConstructComponentLibrarytestCanConstructNestingControllerWhat
Each test method now carries a
@coversannotation naming the class it constructs through the extension's service wiring (BootstrapComponentsService,ComponentLibrary,NestingControllerrespectively), matching the FQCN style already used elsewhere in the unit suite.This clears only the
@coversrisky warnings for these three tests. The remaininggetOutputerrors on those CI rows are unrelated and will be addressed separately.