metadata for pv and pv all#3586
Open
LKuemmel wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds topic metadata for PV (pv) and PV aggregate (pv_all) dataclasses and shifts several PV-related publications from direct MQTT Pub() calls to the centralized ChangedValuesHandler diff-based publisher, including yield updates.
Changes:
- Add
metadata={"topic": ...}to PV and PV-all dataclass fields soChangedValuesHandlercan publish them automatically. - Update yield calculation code to write into the shared
data.data.*model instead of publishing viaPub(). - Extend
ChangedValuesHandlerto publish changes forpv_all_dataand individualpv_dataentries; add a default foropenWB/pv/config/configured.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/helpermodules/update_config.py | Adds default topic openWB/pv/config/configured. |
| packages/helpermodules/measurement_logging/update_yields.py | Stops publishing yields via Pub() and updates the in-memory model instead. |
| packages/helpermodules/changed_values_handler.py | Publishes PV-all and per-PV-module changes via the metadata system. |
| packages/control/pv.py | Adds topic metadata to PV Get fields for auto-publishing. |
| packages/control/pv_all.py | Adds topic metadata to PV-all Config/Get fields and removes direct publishing. |
| packages/control/chargepoint/chargepoint_data.py | Adds topic metadata for daily yields (but currently contains a critical duplicate field issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.