Skip to content

metadata for pv and pv all#3586

Open
LKuemmel wants to merge 2 commits into
openWB:masterfrom
LKuemmel:metadata
Open

metadata for pv and pv all#3586
LKuemmel wants to merge 2 commits into
openWB:masterfrom
LKuemmel:metadata

Conversation

@LKuemmel

Copy link
Copy Markdown
Contributor

No description provided.

@LKuemmel LKuemmel added this to the 2.3.0 milestone Jun 23, 2026
@LKuemmel LKuemmel requested a review from Copilot June 23, 2026 09:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds topic metadata for PV (pv) and PV aggregate (pv_all) dataclasses and shifts several PV-related publications from direct MQTT Pub() calls to the centralized ChangedValuesHandler diff-based publisher, including yield updates.

Changes:

  • Add metadata={"topic": ...} to PV and PV-all dataclass fields so ChangedValuesHandler can publish them automatically.
  • Update yield calculation code to write into the shared data.data.* model instead of publishing via Pub().
  • Extend ChangedValuesHandler to publish changes for pv_all_data and individual pv_data entries; add a default for openWB/pv/config/configured.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/helpermodules/update_config.py Adds default topic openWB/pv/config/configured.
packages/helpermodules/measurement_logging/update_yields.py Stops publishing yields via Pub() and updates the in-memory model instead.
packages/helpermodules/changed_values_handler.py Publishes PV-all and per-PV-module changes via the metadata system.
packages/control/pv.py Adds topic metadata to PV Get fields for auto-publishing.
packages/control/pv_all.py Adds topic metadata to PV-all Config/Get fields and removes direct publishing.
packages/control/chargepoint/chargepoint_data.py Adds topic metadata for daily yields (but currently contains a critical duplicate field issue).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/control/chargepoint/chargepoint_data.py
Comment thread packages/control/pv_all.py
Comment thread packages/helpermodules/measurement_logging/update_yields.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants