Fix various color contrast issues#1618
Open
Arnei wants to merge 3 commits into
Open
Conversation
Touches upon - The "Details >" links in some dialogs - Sub-Header Tabs (e.g. event assets) - Inactive NavBar items (e.g. "Series" when on event page) - Stats Filter - Footer Text
And move relevant css to a more appropriate file.
Only show the "Save" and "Cancel" buttons in the ACL tab if there is something to save or cancel. This is in line with the behaviour of other tabs.
Arnei
force-pushed
the
color-contrast-fixes
branch
from
3dc17b9 to
99d3f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1224
Ups the contrast for some elements.
Also fixes some slight missbehaviour that looks like a css issue in the acl tab.
How to test this.
Can be tested as is, see the first commit for which elements could be affected. Use your favourite accessibility plugin (or your eyes) to check for contrast levels.