Fix use of NODE_VERSION variable#1620
Draft
gregorydlogan wants to merge 12 commits into
Draft
Conversation
gregorydlogan
added
type:bug
…into two components as well.
Member
Author
gregorydlogan
force-pushed
the
t/fix-node-version-variables
branch
from
4fe1f82 to
747ccfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the GHA scripts were unable to find a value for
$NODE_VERSIONwhen installing Node because I was using the variable as a bash shell variable, rather than a GHA templating subtitution. This PR swaps that, so now the builds run.We haven't been noticing this because this only affects PRS based off the current tip of
develop.