CAPI Fix [closed due to branch issues]#1230
Closed
markski1 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Oops. Seems something I did on my fork closed this. It is now at #1231 |
markski1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1199
Currently attempts to release legacy id after real id is released, which destroys the gz and causes the legacy id to be -1. This patch first stores the legacy id to avoid this, which is how it seems to already be done for pawn (Gangzones/Natives.cpp line 44 to 58)
Disclaimer: I've been unable to test this because I cannot make conan and PyYAML play ball with my windows python env. I'll try again when I have time, but this seems straightforwards enough.