[reproducer] Pass extra_variable_files to deployment args for PreMetal#4010
[reproducer] Pass extra_variable_files to deployment args for PreMetal#4010srac0 wants to merge 1 commit into
Conversation
srac0
force-pushed
the
extra-var-files-pre-metal
branch
from
09a0b28 to
1d6a9c7
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
srac0
changed the title
srac0
force-pushed
the
extra-var-files-pre-metal
branch
from
1d6a9c7 to
4a1192c
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 38s |
srac0
force-pushed
the
extra-var-files-pre-metal
branch
3 times, most recently
from
5979158 to
5eea3b0
Compare
openshift-ci
Bot
added
do-not-merge/contains-merge-commits
and removed
do-not-merge/work-in-progress
labels
PreMetal provisions hosts from the main branch, generating reproducer-variables.yml with base scenario vars. During the actual Zuul job, overwrite_zuul_vars.yml only merges zuul_vars.yaml into reproducer-variables.yml, ignoring extra_variable_files entirely. Additionally, the slurp + copy-content pattern for transferring reproducer-variables.yml triggers Jinja2 evaluation on the file content, breaking when the bootstrap bakes raw templates into nested structures. Signed-off-by: Samuel Rac <srac@redhat.com>
srac0
force-pushed
the
extra-var-files-pre-metal
branch
from
4fdd89c to
f849872
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 39s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 33s |
|
Hey @srac0 I've written up another patch to handle some premetal vars funkyness in the event that config files are updated between premetal provision finishing and being picked up for the remainder of the job, would my patch be able to address this issue as well? The idea with my patch is to mirror the way the hypervisor vars are constructed in configure_bm_ocp_controller.yml Feel free to reach out to me on slack to talk premetal stuff, and also if you'd like to join the weekly premetal sync meeting to share any updates/blockers/etc, lmk and I can add you on the invite. Thanks! |
3 participants
PreMetal provisions hosts from the main branch, generating reproducer-variables.yml with base scenario vars. During the actual Zuul job, overwrite_zuul_vars.yml only merges zuul_vars.yaml into reproducer-variables.yml, ignoring extra_variable_files entirely.
This means any scenario override passed via extra_variable_files is silently lost on the controller. The base values from PreMetal provisioning win, causing jobs to run the wrong test plan.
Iteratively merge each extra_variable_files entry into reproducer-variables.yml before the zuul_vars.yaml merge, preserving the correct precedence: base < extra_variable_files < zuul_vars.