Selet AI Tests for Vector Index.#32
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
Pushpendra-Garg
force-pushed
the
vecindex_sync
branch
3 times, most recently
from
730fdcd to
4936204
Compare
| @pytest.fixture(scope="session") | ||
| def credential_connect_as(test_env): | ||
| def _connect_as(admin=False, **overrides): | ||
| select_ai.disconnect() |
There was a problem hiding this comment.
Please don't run select_ai.disconnect() in individual conftest.
We have seen this causes issues as it modifies the global connection state. We already have connect/disconnect in the root level conftest.py which is automatically run for every module.
https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L201
We should not do any connection management in individual test suites.
| @pytest.fixture(scope="session") | ||
| def credential_async_connect_as(test_env): | ||
| async def _connect_as(admin=False, **overrides): | ||
| await select_ai.async_disconnect() |
There was a problem hiding this comment.
We already have async connect and disconnect here
https://github.com/oracle/python-select-ai/blob/main/tests/conftest.py#L208
No need to connect here
|
@Pushpendra-Garg please rebase changes from main. Thanks |
2 participants
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: