Skip to content

feat: tyrael is no more#122

Open
Tyrael wants to merge 1 commit into
php:masterfrom
Tyrael:tyrael/remove-tyrael
Open

feat: tyrael is no more#122
Tyrael wants to merge 1 commit into
php:masterfrom
Tyrael:tyrael/remove-tyrael

Conversation

@Tyrael

@Tyrael Tyrael commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

remove myself from the list of trusted devs as I'm not contributing anymore

@php-pulls

php-pulls commented Nov 28, 2024 via email

Copy link
Copy Markdown

@cmb69

cmb69 commented Nov 29, 2024

Copy link
Copy Markdown
Member

@derickr, we also don't pose as @php-pulls. ;)

I find the rest of the commit message more concerning, anyway. For a moment that sounded like a bereavment.

@Tyrael, I'm fine with the removal, but it doesn't matter much nowadays, since the bug tracker does no longer accept new tickets for a while.

@derickr

derickr commented Nov 29, 2024 via email

Copy link
Copy Markdown
Member

@cmb69

cmb69 commented Nov 29, 2024

Copy link
Copy Markdown
Member

Yes, I know. No worries. :)

Personally, I find these tags ("feat", "chore", etc.) more than useless if not consitently applied, but I don't really mind (I see the old "MFH" commits all the time; that's worse).

@Tyrael

Tyrael commented Nov 29, 2024

Copy link
Copy Markdown
Contributor Author

yeah it's called Conventional Commits, nowadays I have the habbit of using them, I can reword the commit message, but you can also just squash it with whatever commit message you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants