Skip to content

Stabilize discovered SSH host row handler #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Draft

Stabilize discovered SSH host row handler #3485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/web/src/components/settings/ConnectionsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2440,6 +2440,12 @@ export function ConnectionsSettings() {
},
[connectSshEnvironment, savedBackendMode, savedDesktopSshEnvironmentsByAlias],
);
const handleConnectDiscoveredSshHost = useCallback(
(target: DesktopDiscoveredSshHost) => {
void handleConnectSshHost(target);
},
[handleConnectSshHost],
);

const visibleDesktopPairingLinks = desktopPairingLinks;
const tailscaleHttpsEndpoint = useMemo(
Expand Down Expand Up @@ -2663,7 +2669,7 @@ export function ConnectionsSettings() {
key={`${target.alias}:${target.hostname}:${target.port ?? ""}`}
target={target}
connectingHostAlias={connectingSshHostAlias}
onConnect={(nextTarget) => void handleConnectSshHost(nextTarget)}
onConnect={handleConnectDiscoveredSshHost}
/>
))}
{hasLoadedDiscoveredSshHosts &&
Expand Down
Loading