Make ENIP tests tolerate missing root log handlers#121
Open
lazydreamy wants to merge 1 commit into
Open
Conversation
Configure default logging in parser and UDT tests when pytest has not installed a root handler yet. This keeps the existing tests collectable on Python 2 with pytest 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow ENIP parser and UDT tests to be collected when pytest has not installed a root logging handler yet.
Some Python 2 / pytest environments leave the root logger without handlers during test module import. The existing tests immediately access handlers[0], which raises IndexError during collection before the tests can run.
Changes
Testing