fix(core): accept address websocket subscriptions#1278
Conversation
Add watchAddress/unwatchAddress to the sidecar WebSocket method registry so methods declared as ws in method-verbs.json are not rejected before dispatch. Fixes #1177
|
Verification update from autonomous fix launcher: Targeted local checks passed for the WebSocket registry fix:
GitHub generated-sync checks are currently red due unrelated repo-wide generated drift, not this focused WebSocket change. The failed logs show broad changes to |
PR Review: PASS (NOT VERIFIED)What This DoesRegisters Blast RadiusCore sidecar WebSocket dispatch only: Consumer VerificationBefore (base branch): A WebSocket subscribe/unsubscribe for those methods would be rejected by the handler registry before reaching exchange dispatch. After (PR branch): The new Jest test also passed as part of the core test suite. Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- fixes a WebSocket dispatch allow-list regression for existing methods. RiskThe handler now accepts/dispatches address subscriptions, but I did not verify a live venue address stream end-to-end with real credentials; this review verifies the pre-dispatch blocker is removed. |
Summary
watchAddressto the sidecar WebSocket streaming allowlist.unwatchAddressback towatchAddressfor subscription-key lookup during unsubscribe.verb: "ws"inmethod-verbs.jsonare registered by the WebSocket handler.Fixes #1177
Test Plan
npm test --workspace=pmxt-core -- --runTestsByPath test/pipeline/ws-handler-streaming-methods.test.ts --runInBandnpm test --workspace=pmxt-core -- --runTestsByPath test/pipeline/watch-order-book-api.test.ts test/pipeline/get-post-parity.test.ts --runInBandnpm run build --workspace=pmxt-coregit diff --check