Skip to content

Repair backup failed (the value of segment_size is greater than 2G)#510

Open
hslightdb wants to merge 4 commits into
postgrespro:masterfrom
hslightdb:merge510
Open

Repair backup failed (the value of segment_size is greater than 2G)#510
hslightdb wants to merge 4 commits into
postgrespro:masterfrom
hslightdb:merge510

Conversation

@hslightdb

Copy link
Copy Markdown

If the value of segment_size is greater than 2G, the file length will overflow. In this case, the backup will fail.

Comment thread src/catalog.c Outdated
Comment thread src/pg_probackup.h
@hslightdb hslightdb requested review from funny-falcon and removed request for gsmolk and kulaginm October 19, 2022 02:40
@qiuwenhuifx

Copy link
Copy Markdown

@funny-falcon ,I see this problem still exists, are there any plans to fix this?

@qiuwenhuifx

qiuwenhuifx commented Aug 24, 2023

Copy link
Copy Markdown

@funny-falcon
INFO: Backup files are synced, time elapsed: 0
INFO: Validating backup RZW6OO
ERROR: Cannot seek block 261889 of "/data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1": Invalid argument
ERROR: Data files validation failed
pgsql@n97-16-066:~$ du -sh /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1
2.4G /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1

@funny-falcon

Copy link
Copy Markdown
Contributor

Currently there are no plans to fix it, since it quite hard due to backward compatibility issues.

@funny-falcon

Copy link
Copy Markdown
Contributor

Ah, I see: your patch is quite capable. Ok, let me think once more.

@qiuwenhuifx

Copy link
Copy Markdown

@funny-falcon ,It seems n_blocks variable type is int ( file->n_blocks = (int) n_blocks) ,postgrespro has already fixed the (xid 32bit) issue, I think no reason why it can't be fixed!,Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants