ci: check in Cargo.lock and build with --locked#306
Open
krisztianfekete wants to merge 1 commit into
Open
Conversation
Member
|
Given this being a dev-dependency, how about checking in a |
Collaborator
Author
That has been my original idea, but thought it's not the pattern we'd like to follow here given it has never been committed to the repo, and CI lacked |
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
b2d9cd1 to
e9300ca
Compare
Collaborator
Author
|
@mxinden, can you please take a look when you have a chance? |
Collaborator
Author
|
@mxinden sorry for the ping, but I'd like to fix the upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial approach:
New approach:
--lockedin CI for reproducible builds, as suggested in review. This holds the time dep at a version that compiles, working around the regression above.