Fix default no-response behavior for force listen only#2941
Merged
janiversen merged 2 commits intoJun 24, 2026
Merged
Conversation
janiversen
approved these changes
Jun 24, 2026
janiversen
left a comment
Collaborator
There was a problem hiding this comment.
You can actívate or deactivate the function, so the default value does not really matter.
However your point about the documentation is correct.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the default behavior of
diag_force_listen_only().Previously, the method used
no_response_expected=Falseby default, so the client would wait for a reply after sendingForce Listen Only Mode.According to the Modbus specification for Diagnostics sub-function
0x08 / 0x0004, no response is returned for this request.Change
diag_force_listen_only(..., no_response_expected=False)diag_force_listen_only(..., no_response_expected=True)Rationale
This aligns the client default behavior with the protocol and with the method's own docstring, which already states that no response is returned.
Without this change, a default call to
diag_force_listen_only()can incorrectly fall into a timeout or retry path even when the request was successfully accepted by the remote device.