Support configured ASCII input delimiter#2942
Open
MrAlaskan wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
FramerAsciiso thatChange ASCII Input Delimiteractually affects future ASCII messages.Previously, the delimiter value was updated in the control block, but the ASCII framer still used a hardcoded
CRLFterminator for both encoding and decoding.According to the Modbus ASCII specification, the
Change ASCII Input Delimiterdiagnostic command replaces the defaultLFcharacter used at the end of future messages.Change
FramerAsciinow builds its end-of-frame marker from the control block delimiter instead of always using a hardcodedCRLFdecode()now looks for the configured delimiterencode()now emits the configured delimiterLF, so the default end-of-frame remainsCRLFRationale
This aligns the framer behavior with both the protocol and the existing diagnostic command implementation.
Without this change,
Change ASCII Input Delimiterupdates internal state but does not affect actual frame parsing or frame generation, so the command appears to succeed while the wire behavior remains unchanged.