reject tab characters in bare keys#497
Open
netliomax25-code wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_bare_keyconsumes spaces and tabs while reading a bare key, then strips outer whitespace and only rejects the key if it still contains a literal space, so an interior tab is never caught.a\tb = 1,[a\tb],x.y\tz = 1), which the spec disallows and which stdlibtomlliband the official toml-test corpus reject.Changed the check to reject the key when the stripped value contains a space or a tab. Validation stays in the parser since callers receive the already-built key.
Verified against the failing inputs above, the existing parser tests, and the full toml-test suite. Added a regression test that fails before the change and passes after.