gh-149965: Improve thread-safety in ElementObjects within element_ass_subscr#149966
Closed
clin1234 wants to merge 23 commits into
Closed
gh-149965: Improve thread-safety in ElementObjects within element_ass_subscr#149966clin1234 wants to merge 23 commits into
element_ass_subscr#149966clin1234 wants to merge 23 commits into
Conversation
clin1234
changed the title
element_ass_subscr
sergey-miryanov
requested changes
May 18, 2026
|
|
||
| // Pointer-by-pointer memmove for PyObject** arrays that is safe | ||
| // for shared ElementObjects in Py_GIL_DISABLED builds. | ||
| static void |
Contributor
There was a problem hiding this comment.
I'm not sure we should duplicate ptr_wise_atomic_memmove here.
Could you please link to the related C-API Working group issue in this PR, and cross-reference it in the original issue?
Contributor
Author
There was a problem hiding this comment.
Since the function is not exposed as part of the public API, I don't think linking a C-API Working Group issue is needed here.
Anyway, it's inspired by #149936
Contributor
There was a problem hiding this comment.
I'll add a link to capi-workgroup/decisions#106 for traceability.
dimaqq
reviewed
Jun 9, 2026
| // Pointer-by-pointer memmove for PyObject** arrays that is safe | ||
| // for shared ElementObjects in Py_GIL_DISABLED builds. | ||
| static void | ||
| ptr_wise_atomic_memmove(ElementObject *a, PyObject **dest, PyObject **src, Py_ssize_t n) |
Contributor
There was a problem hiding this comment.
This function needs own set of unit tests, for:
- gil disabled
- single owner
- dest < src
- dest > str
- dest == src
- crazy, but someone will call it this way
- or an hard assertion forbidding such call
- or a short-circuit path if it's a no-on
- dest != src, but ranges overlap
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Jun 9, 2026
…ternal helper and add unit tests Extract the duplicated static `ptr_wise_atomic_memmove` from `Modules/_elementtree.c` and `Objects/listobject.c` into a shared `static inline _Py_ptr_wise_atomic_memmove(PyObject *a, ...)` in `Include/internal/pycore_object.h`. The first parameter is generalised from a type-specific pointer to `PyObject *` since only `PyObject *`- level operations (`_Py_IsOwnedByCurrentThread`, `_PyObject_GC_IS_SHARED`) were ever performed on it. `listobject.c` previously embedded `_Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED` inside the local helper. That assertion is preserved by moving it explicitly to each of the four call sites in `listobject.c` (which are all called under a critical section). `_elementtree.c`'s open question about whether a critical section is needed remains unanswered, so no assertion is added there. Unit tests are added in `Modules/_testinternalcapi/test_ptr_wise_memmove.c` covering: dest < src (forward copy), dest > src (backward copy), dest == src (no-op), overlapping ranges, and the single-owner fast path. The single-owner test explicitly clears the GC SHARED bit to guard against freelist reuse leaving the bit set from a sibling test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
clin1234
requested review from
a team,
AA-Turner,
emmatyping,
erlend-aasland and
itamaro
as code owners
Commented out critical section assertion for ElementObject.
…FW3ZD.rst Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
…ternal helper and add unit tests Extract the duplicated static `ptr_wise_atomic_memmove` from `Modules/_elementtree.c` and `Objects/listobject.c` into a shared `static inline _Py_ptr_wise_atomic_memmove(PyObject *a, ...)` in `Include/internal/pycore_object.h`. The first parameter is generalised from a type-specific pointer to `PyObject *` since only `PyObject *`- level operations (`_Py_IsOwnedByCurrentThread`, `_PyObject_GC_IS_SHARED`) were ever performed on it. `listobject.c` previously embedded `_Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED` inside the local helper. That assertion is preserved by moving it explicitly to each of the four call sites in `listobject.c` (which are all called under a critical section). `_elementtree.c`'s open question about whether a critical section is needed remains unanswered, so no assertion is added there. Unit tests are added in `Modules/_testinternalcapi/test_ptr_wise_memmove.c` covering: dest < src (forward copy), dest > src (backward copy), dest == src (no-op), overlapping ranges, and the single-owner fast path. The single-owner test explicitly clears the GC SHARED bit to guard against freelist reuse leaving the bit set from a sibling test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ible on instances (pythonGH-139820) Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Contributor
Author
|
@ericsnowcurrently, mind taking a look on helping me on resolving the mutable global variable issue in |
Member
|
I tzhink the merge was messed up. There are unrelated changes. Please re-open a cleaner PR. |
hugovk
removed request for
a team,
1st1,
AA-Turner,
asvetlov,
emmatyping,
ericsnowcurrently,
erlend-aasland,
ezio-melotti,
freakboy3742,
gpshead,
hugovk,
itamaro,
kumaraditya303,
mhsmith,
picnixz,
savannahostrowski,
sethmlarson,
webknjaz and
willingc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also capi-workgroup/decisions#106