gh-151112: Fix crash in compiler_mod() when entering the current compilation unit fails#151234
Open
StanFromIreland wants to merge 1 commit into
Open
gh-151112: Fix crash in compiler_mod() when entering the current compilation unit fails#151234StanFromIreland wants to merge 1 commit into
compiler_mod() when entering the current compilation unit fails#151234StanFromIreland wants to merge 1 commit into
Conversation
iritkatriel
reviewed
Jun 10, 2026
| co = _PyCompile_OptimizeAndAssemble(c, addNone); | ||
| finally: | ||
| _PyCompile_ExitScope(c); | ||
| if (c->u != NULL) { |
Member
There was a problem hiding this comment.
Are we sure c->u was NULL when we entered compiler_mod? Can we assert that at the top of the function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyCodegen_EnterAnonymousScopecan fail to enter the module's compilation unit (e.g. when OOM, like the in repro), soc->uis left NULL.compiler_mod's cleanup then calls_PyCompile_ExitScope, which derefs that NULL unit incompiler_unit_freeand segfaults.The reproducers start/stop for nomemory will probably have to be adjusted, but for me I can reproduce with:
Skipping news, the other PR has one which I think can cover this too, these are both quite rare.