Validate release-file URL metadata#3014
Merged
Merged
Conversation
sethmlarson
suggested changes
Jun 3, 2026
sethmlarson
left a comment
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Some comments:
Contributor
Author
|
Thanks for the review. I pushed a follow-up commit that addresses the comments:
|
sethmlarson
approved these changes
Jun 4, 2026
sethmlarson
left a comment
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you! I wasn't able to "resolve" the threads, maybe you are able to?
Reject new or changed non-HTTPS release-file URLs and reject sidecar URLs that do not extend the artifact URL they describe. Apply the validation in model forms, DRF writes, and Tastypie writes while leaving unchanged legacy HTTP rows editable. Add model and API regression coverage for create and update paths.
Future-proof ReleaseFile URL metadata tests by checking the configured URL fields against the model fields and checking sidecar suffix coverage. Assert the v1 and v2 validation response bodies for rejected release-file URL writes, replace the copied hash-length filesize values, and inline the URL validation helpers.
e-q
force-pushed
the
release-file-url-validation
branch
from
a4b1d62 to
340d2eb
Compare
Contributor
Author
|
Rebased onto latest main and resolved the conflicts. The only substantive resolution note is that v1 detail updates now keep upstream's 405 behavior. |
JacobCoffee
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
including existing mismatched sidecars edited through unrelated metadata
changes.
and new invalid values.
Closes
Testing
including create and update paths: passed.