-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Allow IPv6 datagram protocol addresses #15891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
popsiclelmlm
wants to merge
1
commit into
python:main
Choose a base branch
from
popsiclelmlm:codex/asyncio-datagram-addr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
stdlib/@tests/test_cases/asyncio/check_datagram_protocol.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
|
|
||
|
|
||
| class IPv4DatagramProtocol(asyncio.DatagramProtocol): | ||
| def datagram_received(self, data: bytes, addr: tuple[str, int]) -> None: ... | ||
|
|
||
|
|
||
| class IPv6DatagramProtocol(asyncio.DatagramProtocol): | ||
| def datagram_received(self, data: bytes, addr: tuple[str, int, int, int]) -> None: ... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||||
| from _typeshed import ReadableBuffer | ||||||||||||
| from asyncio import transports | ||||||||||||
| from typing import Any | ||||||||||||
| from socket import _RetAddress | ||||||||||||
|
|
||||||||||||
| # Keep asyncio.__all__ updated with any changes to __all__ here | ||||||||||||
| __all__ = ("BaseProtocol", "Protocol", "DatagramProtocol", "SubprocessProtocol", "BufferedProtocol") | ||||||||||||
|
|
@@ -27,11 +27,10 @@ class BufferedProtocol(BaseProtocol): | |||||||||||
| class DatagramProtocol(BaseProtocol): | ||||||||||||
| __slots__ = () | ||||||||||||
| def connection_made(self, transport: transports.DatagramTransport) -> None: ... # type: ignore[override] | ||||||||||||
| # addr can be a tuple[int, int] for some unusual protocols like socket.AF_NETLINK. | ||||||||||||
| # Use tuple[str | Any, int] to not cause typechecking issues on most usual cases. | ||||||||||||
| # This could be improved by using tuple[AnyOf[str, int], int] if the AnyOf feature is accepted. | ||||||||||||
| # See https://github.com/python/typing/issues/566 | ||||||||||||
| def datagram_received(self, data: bytes, addr: tuple[str | Any, int]) -> None: ... | ||||||||||||
| # addr varies by socket family and can be a tuple[str, int, int, int] for IPv6, | ||||||||||||
| # tuple[int, int] for some unusual protocols like socket.AF_NETLINK, or other | ||||||||||||
| # shapes. Keep this aligned with socket.recvfrom's return address type. | ||||||||||||
| def datagram_received(self, data: bytes, addr: _RetAddress) -> None: ... | ||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using
Suggested change
|
||||||||||||
| def error_received(self, exc: Exception) -> None: ... | ||||||||||||
|
|
||||||||||||
| class SubprocessProtocol(BaseProtocol): | ||||||||||||
|
|
||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For performance and other reasons we only use tests in extraordinary or edge cases. These tests basically test whether type checkers process
Anycorrectly. We don't need them.