Fix backend build: migrate DjangoAdminEditorModal to Radix Dialog#4668
Conversation
PR #4664 removed shared/modal.tsx but django-admin-editor-modal still imported it, breaking the vite client build in the backend Docker image. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Migrates Early return before The component guards with Iframe height reduction The iframe changed from Missing No |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 359 359
Lines 10800 10800
Branches 821 821
=======================================
Hits 9993 9993
Misses 696 696
Partials 111 111 🚀 New features to boost your workflow:
|
Summary
The backend Docker build on
mainis failing (run 27280034017) with:#4664 (Migrate custom_admin Schedule Builder to Radix UI) deleted
shared/modal.tsxbut misseddjango-admin-editor-modal/index.tsx, which still imported it. This migrates that last consumer to the same RadixDialogpattern used by the rest of #4664.The iframe modal keeps its ~90vw footprint via
Dialog.Content width/maxWidth; a visually hiddenDialog.Titlekeeps Radix's accessibility requirement satisfied. Closing the dialog still triggers theConferenceSchedulerefetch.Test plan
pnpm buildinbackend/custom_admin(node:23 container, same as Dockerfile js-stage) — previously failed at the client vite stage, now completes🤖 Generated with Claude Code