Remove validate-quick-start-module workflow and the create-issue step#2081
Merged
Conversation
Two cleanups to the quick start workflows: - Delete .github/workflows/validate-quick-start-module.yml. The validation is no longer needed here. - Drop the "Create Issue if failed" step from update-quick-start-module.yml. It used dacbd/create-issue-action@main -- an unpinned third-party action pinned to a mutable branch -- and handed it the long-lived PYTORCHBOT_TOKEN PAT, which is broader than issue creation needs. Removing the step is the simplest fix and eliminates the supply-chain exposure; the workflow's failure is still visible from the scheduled run's status. This PR was authored with the assistance of an AI coding assistant.
✅ Deploy Preview for pytorch-dot-org-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanups to the quick start GitHub Actions workflows:
validate-quick-start-module.yml— this validation workflow is no longer needed here.Validation is done here: https://github.com/pytorch/test-infra/blob/main/.github/workflows/validate-binaries.yml after every RC, before and after the Release
update-quick-start-module.yml.Why remove the create-issue step
The step used
dacbd/create-issue-action@mainand passed itsecrets.PYTORCHBOT_TOKEN:This is a supply-chain exposure:
@mainref, so any future (or compromised) commit runs in our job.PYTORCHBOT_TOKEN), far more privileged than opening an issue requires. A malicious version could exfiltrate it; thepytorchbot-envenvironment gates release of the secret but does not stop the third-party action from reading it once the job runs.Since the failure is already visible from the scheduled run's status, the step isn't needed — removing it is the simplest fix and eliminates the exposure. The
Create Pull Requeststep is unchanged (it legitimately needs a PAT so the PR triggers CI).This PR was authored with the assistance of an AI coding assistant.