fix(config): fall back to USERPROFILE for config dir on Windows (DX-5667)#26
Merged
Merged
Conversation
…667) On Windows, shells set USERPROFILE rather than HOME, so config_dir() returned None and 'qn auth login' failed with 'no config directory available on this platform'. The home directory now resolves from HOME first, then USERPROFILE, keeping the same ~/.config/qn/config.toml layout on every platform. Unix behavior is unchanged. Also makes the no-config-directory error actionable (name the env vars to set, or --config-file) and documents the Windows path in the README. Adds 3 unit tests for the resolver (USERPROFILE fallback, HOME precedence, all-unset).
yorsant
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qn auth loginfailed withno config directory available on this platform: shells there setUSERPROFILErather thanHOME, and the config-dir resolver only consultedXDG_CONFIG_HOME/HOME. The home directory now resolves fromHOMEfirst, thenUSERPROFILE, keeping the same~/.config/qn/config.tomllayout on every platform (%USERPROFILE%\.config\qn\config.tomlon Windows). Unix behavior is unchanged.--config-file), and the README documents the Windows path.Closes DX-5667
Test plan
cargo test— 199 tests pass, including 3 new resolver unit tests (USERPROFILE fallback, HOME precedence over USERPROFILE, all-unset returns None)cargo clippy --all-targets -- -D warningsandcargo fmt --checkcleanenv -u HOME -u XDG_CONFIG_HOME USERPROFILE=/tmp/qn-up ./target/debug/qn auth logoutsucceeds (previously errored); with no home vars at all, the new actionable error is shown