drm/gem-framebuffer: Don't validate buffer size when non-linear#7427
Open
6by9 wants to merge 1 commit into
Open
drm/gem-framebuffer: Don't validate buffer size when non-linear#74276by9 wants to merge 1 commit into
6by9 wants to merge 1 commit into
Conversation
pitch*height does not necessarily equate to buffer size if the buffer is non-linear, so the buffer validation is invalid. Disable it for non-linear buffers. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
pelwell
approved these changes
Jun 9, 2026
popcornmix
approved these changes
Jun 9, 2026
Collaborator
|
(suitable for upstream?) |
Contributor
Author
Yes, it'll be one of those fun conversations with them as part of trying to "fix" SAND handling now that they declared DRM modifiers to be effectively static values rather than able to carry dynamic data (eg the column height). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pitch*height does not necessarily equate to buffer size if the buffer is non-linear, so the buffer validation is invalid.
Disable it for non-linear buffers.