rust_1_96: support std::range types#1792
Open
dhardy wants to merge 6 commits into
Open
Conversation
dhardy
force-pushed
the
push-mlmorwszrtvl
branch
from
ed3331a to
67c419a
Compare
newpavlov
reviewed
Jun 24, 2026
| alloc = [] | ||
|
|
||
| # Option: support the std::range types (requires Rust >= 1.96.0). | ||
| rust_1_96 = [] |
Member
There was a problem hiding this comment.
IMO we should just bump rust-version and be done with it. Situations like this are what MSRV-aware resolver was introduced for.
Should we do it now or later is a separate question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Support construction of
UniformviaTryFromand sampling usingSampleRangewithstd::rangetypes, mirroring existing support forstd::opsrange types.Since this requires Rust 1.96 which is newer than our MSRV, introduce a
rust_1_96feature gate (will be dropped after the MSRV advances sufficiently).Motivation
Closes #1784, #1785. CC @kristoff-mattei.
Details
Includes some doc tweaks:
