[CI] Add draft release step to GitHub Actions workflow#644
Open
YooSunYoung wants to merge 7 commits into
Open
Conversation
github-actions
Bot
changed the title
Removed echo statement for TAG in release workflow.
Member
Author
|
Sorry for pushing things continuously... it's now really ready...! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release note upload job failed because the release was not drafted/published yet.
It was depending on the assets uploading job to create the release if not present.
It used default values for creating the release if there is None for the given tag.
Then the title was set to a weird commit message instead of the tag name (it depends on how many commits belong to the PR apparently?).
So I added an explicit release draft step with the specific title(tag name).
In this way we can use the runners a bit more efficiently... (release note generating and docs build can take a while.)
Also I removed the upload file action and used
ghcli directly instead.The release note uploading job is responsible for publishing the release,
i.e. the release is set to latest/published from draft when there is a release note.
Assets uploading (built docs) won't be necessarily done by the time the release is published.