Skip to content

perf(points): strip alpha on unique colours, not once per point #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtreis merged 2 commits into from
Jun 6, 2026
Merged

perf(points): strip alpha on unique colours, not once per point #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
407b494
perf(points): strip alpha on unique colours, not once per point
timtreis Jun 6, 2026
df347bf
refactor(points): drop no-op inverse.reshape(-1)
timtreis Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/spatialdata_plot/pl/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,11 @@ def _render_points(
and isinstance(color_vector[0], str)
and color_vector[0].startswith("#")
):
color_vector = np.asarray([_hex_no_alpha(c) for c in color_vector])
# color_vector usually holds only a few distinct hex strings (one per
# category), so strip alpha on the unique values and map back rather than
# calling the per-string parser once per point.
unique_hex, inverse = np.unique(color_vector, return_inverse=True)
color_vector = np.asarray([_hex_no_alpha(c) for c in unique_hex])[inverse]

shade_how = render_params.density_how if render_params.density else "linear"
# Plain density (no color column) must use the user-facing cmap as a sequential
Expand Down
Loading