Skip to content

Set panel title/aspect/frameon once per panel, not per render command #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timtreis wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −13
Open

Set panel title/aspect/frameon once per panel, not per render command #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/spatialdata_plot/pl/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,19 +1794,21 @@ def _draw_colorbar(
colorbar_requests=axis_colorbar_requests,
)

if title is None:
t = panel_key if panel_key is not None else cs
elif len(title) == 1:
t = title[0]
else:
try:
t = title[i]
except IndexError as e:
raise IndexError("The number of titles must match the number of panels.") from e
ax.set_title(t)
ax.set_aspect("equal")
if fig_params.frameon is False:
ax.axis("off")
# Title/aspect/frameon are panel-level: set once per panel, after the
# per-command loop above (not once per render command).
if title is None:
t = panel_key if panel_key is not None else cs
elif len(title) == 1:
t = title[0]
else:
try:
t = title[i]
except IndexError as e:
raise IndexError("The number of titles must match the number of panels.") from e
ax.set_title(t)
ax.set_aspect("equal")
if fig_params.frameon is False:
ax.axis("off")

if has_shapes and wants_shapes:
empty_shape_elements = [
Expand Down
Loading