Optimize dynamic schemas#1255
Merged
Merged
Conversation
391dd60 to
a6abf91
Compare
a6abf91 to
3155849
Compare
mtdowling
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
No observable behavior change. Dynamic-schema document serde produces the same
output for the same input. This is purely internal: less allocation and faster
serialize/deserialize for StructDocument / ContentDocument, especially for
union-dense payloads (e.g. DynamoDB AttributeValue) and string/enum lists.
Why is this change needed?
Performance. The old path wrapped every leaf value in a second Document and
stored struct members in a LinkedHashMap keyed by member name. This added an
allocation per leaf plus map overhead per struct. The hot serialize call site
was also megamorphic, so C2 couldn't inline it.
How was this validated?
allocation / throughput wins.
What should reviewers focus on?
Instant/ByteBuffer/List/Map) instead of wrapping a Document. Look at
serializeContents / serializeScalar (kept in sync by hand) and the
string/enum list fast-path in serializeListContents.
member-index-keyed Document[] instead of a LinkedHashMap; unions store the
single set value raw (no ContentDocument wrapper). Reusable consumer objects
replace per-call closures.
document-typed members).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.