[FEM] Refactor templates in latest FEM classes#6124
Open
alxbilger wants to merge 15 commits into
Open
Conversation
alxbilger
added
pr: status to review
alxbilger
force-pushed
the
refactoringtemplatefem
branch
from
83f01b3 to
b5016d0
Compare
Contributor
|
Conflicts to be solved @alxbilger |
alxbilger
force-pushed
the
refactoringtemplatefem
branch
from
c6dd38d to
92e3339
Compare
alxbilger
force-pushed
the
refactoringtemplatefem
branch
from
92e3339 to
2926653
Compare
fredroy
force-pushed
the
refactoringtemplatefem
branch
from
2926653 to
de39a66
Compare
fredroy
added
pr: status ready
Contributor
|
[ci-build][with-all-tests] |
fredroy
force-pushed
the
refactoringtemplatefem
branch
from
de39a66 to
c4e557f
Compare
* clean dirtiness of data that are input of callback Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com> * Fix: remove the std::cout --------- Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…ramework#6157) * [Mesh] Remove symbol export on template class BlenderExporter * same for TopologyBoundingTrasher
…actoringtemplatefem
Contributor
Author
|
The CUDA force fields are not a template specialization. They are new classes deriving from the CPU class. Therefore, the component name takes the class name. That is why there is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest FEM classes defined custom names and custom template names so that the class is registered in the factory with this custom name. However, this is not a good practice. This PR restores the regular pattern where the class is registered using its own class. Because of this, I could also remove the
Elementprefix on all the FEM classes.Before:
<PrismFEMMass/>After:
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if