[Core] Move SceneCheckerVisitor out of the SceneChecking project into the core

[bakpaul]

Moves the SceneCheck visitor into the core. This is required for the SofaPython3 PR enabling scene checking when launching a scene using python.

[with-all-tests]
[force-full-build]

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[sofabot]

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[sofabot]

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[sofabot]

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[fredroy]

no compatibility ? 🫢
(the headers moved and the namespace changed...)

[hugtalbot]

Agreed with @fredroy
Ready after compat'

[bakpaul]

You think that anyone implemented a scene check on his own outside of the core devs ? And even if it is the case, this is the visitor, surely no one is using it outside thee core dev. I really think the "compatibility layer" should be restricted to parts of the code that really has potential to be used by the community, because it takes time to take care of it properly. But well if necessary then I'll do it.

[fredroy]

You think that anyone implemented a scene check on his own outside of the core devs ? And even if it is the case, this is the visitor, surely no one is using it outside thee core dev. I really think the "compatibility layer" should be restricted to parts of the code that really has potential to be used by the community, because it takes time to take care of it properly. But well if necessary then I'll do it.

Well, the problem is how to judge something is "really has potential to be used by the community,".
But personally I am no hell-bent on this compat (I did not set "Request changes" 🫢), but it needs at least the flag pr:breaking , to be notified by the changelog produced at the release stage.

[sofabot]

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[sofabot]

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[fredroy]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d13d82357b1de1240603cf07f39e1b772f3a96c4'

[sofabot]

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='46857d6d34e90628304c3935ea32b01c70f587c0'

[bakpaul]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='46857d6d34e90628304c3935ea32b01c70f587c0'

[fredroy]

[ci-build][with-all-tests]

[sofabot]

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d5ef5374037d64b0aeef06b70c722146060d4afd'

[hugtalbot]

Compilation fails :

external_directories/fetched/SofaPython3/bindings/Sofa/src/SofaPython3/Sofa/Simulation/Submodule_Simulation.cpp:74:92: error: 'PluginLoadStatus' has not been declared
   74 |         if(res == sofa::helper::system::PluginManager::PluginLoadStatus::SUCCESS || res == PluginLoadStatus::ALREADY_LOADED)

[sofabot]

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

• Merge or close Enable scene checking when launching through python SofaPython3#616
  For this build, the following CMake flags will be set
  -DSOFAPYTHON3_GIT_REPOSITORY='https://github.com/sofa-framework/SofaPython3'
  -DSOFAPYTHON3_GIT_TAG='d5ef5374037d64b0aeef06b70c722146060d4afd'