Skip to content

[Scenes] SofaCUDA: ignore newly introduced scenes, and restore scenes parameters#6158

Merged
bakpaul merged 3 commits into
sofa-framework:masterfrom
fredroy:ignore_new_cuda_scenes
Jun 18, 2026
Merged

[Scenes] SofaCUDA: ignore newly introduced scenes, and restore scenes parameters#6158
bakpaul merged 3 commits into
sofa-framework:masterfrom
fredroy:ignore_new_cuda_scenes

Conversation

@fredroy

@fredroy fredroy commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
  1. For the github CI we need to ignore SofaCUDA scenes
    [SofaCUDA] ElementFEMForceField: Generic CUDA implementation #6071 introduced new ones, so we must ignore them too

  2. [SofaCUDA] ElementFEMForceField: Generic CUDA implementation #6071 also changed the number of elements for the beam's validation scenes, it appears the CI did not appreciate 🫢

But I am wondering why the actions on #6071 were all green before it was merged 🤔
(https://github.com/sofa-framework/sofa/actions/runs/27522973705)

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jun 15, 2026
@fredroy

fredroy commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy changed the title [SofaCUDA] CI: ignore newly introduced scenes [Scenes] SofaCUDA: ignore newly introduced scenes, and restore scenes parameters Jun 16, 2026
@bakpaul bakpaul merged commit 409db6b into sofa-framework:master Jun 18, 2026
21 of 23 checks passed
@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 18, 2026
@fredroy fredroy deleted the ignore_new_cuda_scenes branch June 18, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants