[Scenes] SofaCUDA: ignore newly introduced scenes, and restore scenes parameters#6158
Merged
Merged
Conversation
Contributor
Author
|
[ci-build][with-all-tests] |
hugtalbot
approved these changes
Jun 18, 2026
bakpaul
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the github CI we need to ignore SofaCUDA scenes
[SofaCUDA] ElementFEMForceField: Generic CUDA implementation #6071 introduced new ones, so we must ignore them too
[SofaCUDA] ElementFEMForceField: Generic CUDA implementation #6071 also changed the number of elements for the beam's validation scenes, it appears the CI did not appreciate 🫢
But I am wondering why the actions on #6071 were all green before it was merged 🤔
(https://github.com/sofa-framework/sofa/actions/runs/27522973705)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if