docs: propagate recent develop fixes to sibling packages#12642
Merged
Conversation
Propagates fix from 95016b8 ("fix: add missing import in `ndarray/base/unflatten` declarations") to the sibling `ndarray/base/to-unflattened` declaration, which uses bare `ArrayLike<number>` without an import.
Propagates fix from 3116666 ("docs: correct TSDoc across `ndarray` TypeScript declarations") to sibling REPL documentation. The TSDoc fix dropped the ungrammatical article "a" before "provided broadcast-incompatible ndarrays" in three `.d.ts` files; the same wording persisted in the corresponding `docs/repl.txt` files.
Propagates fix from f3b8c81 ("chore: clean-up examples and benchmarks") to sibling `blas/ext/base/*/lib/accessors.js` packages where the singular `Cache reference to ...` comment precedes multiple cached references. Edits are scoped per package: the array-data line is pluralized only where two or more `.data` buffers are cached, and the element-accessors line is pluralized (with the redundant article dropped) only where two or more `.accessors[N]` entries are cached.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-06-05 20:40:09 -0700 (5c51a78e) and 2026-06-06 04:44:41 -0700 (f3b8c813) to sibling packages with the same underlying defect.Pattern: missing
Collectionimport inndarray/base/to-unflatteneddeclarationsThis propagates the fix from 95016b8 to
@stdlib/ndarray/base/to-unflattened, which has the identical defect: thesizesparameter was typed as the TypeScript built-inArrayLike<number>rather than stdlib'sCollection<number>, and the correspondingimport { Collection } from '@stdlib/types/array'was absent from the declaration file. The fix adds the missing import and updates the parameter type, bringing the declaration into alignment with the rest ofndarray/base.95016b8c(fix: add missing import inndarray/base/unflattendeclarations)@stdlib/ndarray/base/to-unflattenedPattern: drop spurious article in REPL docs
Propagates the TSDoc fix from 3116666, which dropped the ungrammatical article "a" from the phrase "if a provided broadcast-incompatible ndarrays," to the corresponding
docs/repl.txtfiles in@stdlib/ndarray/base/maybe-broadcast-arrays,@stdlib/ndarray/maybe-broadcast-arrays, and@stdlib/ndarray/iter/interleave-subarrays. The source PR corrected the TypeScript declarations but left the same wording in the REPL help text untouched. This commit brings the threerepl.txtfiles into agreement with the corrected declarations.3116666b(docs: correct TSDoc acrossndarrayTypeScript declarations)@stdlib/ndarray/base/maybe-broadcast-arrays@stdlib/ndarray/maybe-broadcast-arrays@stdlib/ndarray/iter/interleave-subarraysPattern: pluralize cache-reference comments in
blas/ext/base/*accessorsPropagates the comment clean-ups from f3b8c81 across sibling
blas/ext/base/*/lib/accessors.jsfiles that carry the same stale singular phrasing. Two defects are addressed per file: Defect A pluralizes// Cache reference to array data:where two or more.databuffers are cached, and Defect B pluralizes// Cache reference to the element accessors:(also dropping the redundant article) where two or more.accessors[N]entries are cached. Files with only a single such reference are left untouched, as pluralizing there would be grammatically incorrect.f3b8c813(chore: clean-up examples and benchmarks).data):@stdlib/blas/ext/base/gcusumkbn@stdlib/blas/ext/base/gcusumkbn2@stdlib/blas/ext/base/gcusumors@stdlib/blas/ext/base/gcusumpw@stdlib/blas/ext/base/gnannsumkbn@stdlib/blas/ext/base/gsort2hp@stdlib/blas/ext/base/gsort2ins@stdlib/blas/ext/base/gsort2sh.accessors[N]):@stdlib/blas/ext/base/gapx@stdlib/blas/ext/base/gaxpb@stdlib/blas/ext/base/gcusumkbn@stdlib/blas/ext/base/gcusumkbn2@stdlib/blas/ext/base/gcusumors@stdlib/blas/ext/base/gnannsumkbn@stdlib/blas/ext/base/gsort2hp@stdlib/blas/ext/base/gsort2ins@stdlib/blas/ext/base/gsort2sh@stdlib/blas/ext/base/gsorthp@stdlib/blas/ext/base/gsortins@stdlib/blas/ext/base/gsortsh@stdlib/blas/ext/base/gxsaRelated Issues
None.
Questions
No.
Other
Validation
ndarray/base/*/docs/types/*.d.tsfor the missing-import sweep;**/docs/repl.txtfor the broadcast-wording sweep;blas/ext/base/*/lib/accessors.jsfor the cache-comment sweep).to-unflatteneddeclaration, that thesizesparameter is semantically a list of dimension sizes (matchingunflatten'ssizessemantics); for each REPL doc, that the file is hand-authored (no autogen marker) and the typo is verbatim; for each accessors file, that the comment text matches exactly and is followed by ≥2 immediately-following.data/.accessors[N]lines without an intervening blank — and (c) the proposed patch matches the source commit's exact shape.Collectionimport slots in before thendarrayimport (alphabetical) and matches the source-commit ordering, and that the per-fileaccessors.jspatches each replace a unique single-line occurrence.gcusumpw's Defect-B line as already-plural (only its Defect-A line is patched here).Deliberately excluded
ArrayLike<number>→Collection<number>sweep acrossndarray/base/*/docs/types/*.d.ts: those files are not broken (TypeScript's lib providesArrayLikeas a global), so this is a codebase-convention question that should be a deliberate human decision rather than an automated propagation. Flagged for follow-up.ndarray/docs/types/index.d.ts,ndarray/base/docs/types/index.d.ts,ndarray/iter/docs/types/index.d.ts) and therepl/help/data/data.{csv,json}files that still carry the broadcast-incompatible typo: these are generator-owned aggregates and will be regenerated from the per-package sources patched here.gcusumpwDefect-B line: the comment already readsCache references to the element accessors:(plural, but retains the redundant article). The exact source-commit old-string does not match, so this propagation deliberately does not touch it.filled(false, len)→falses(len, dtype)/Uint8Array→BooleanArraymodernization inf3b8c813's examples / benchmarks / READMEs: this is an API adoption rather than a defect propagation, and applying it acrossblas/ext/base/*would cascade into example/benchmark rewrites that exceed self-contained-patch scope.array/truesdtype-default audit (517d71c3): already correct in the newarray/truespackage — no propagation site.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to
developover the prior 24 hours. Candidate source commits were filtered for generalisable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents (two opus validation passes, one opus adaptation pass, one sonnet style-consistency pass) before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code