This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Master without client api#1317
Open
bdemers wants to merge 24 commits into
Open
Conversation
Contributor
Author
|
green means go! |
Contributor
Author
|
@dogeared bump |
dogeared
reviewed
Mar 29, 2017
| ;; | ||
| run) | ||
| SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd) | ||
| CI_DIR_CONTENTS=`ls $SCRIPT_DIR/ci` |
Member
There was a problem hiding this comment.
Is this necessary? I don't think it's even outputting the CI_DIR_CONTENTS anyway
Contributor
Author
There was a problem hiding this comment.
I would say no, but I'll let you ask the author: 1afd2a8 🔥
Contributor
Author
There was a problem hiding this comment.
I kid, I kid, I just checked the build log, and I don't see that log line, I'll remove those and merge
Member
|
@bdemers - one minor comment. LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff of the pull request is going to look jacked.
Compare it with 1.5.x and it should look fine.
1.5.x...master-without-client-api
This basically moves master back to 1.5.x (without changing the version poms)
cc: @dogeared