refactor(bench): WorkerBackendType = SDK BackendType (A-converge step 1)#294
Merged
Conversation
…ting literal copy) The hand-maintained 6-value union (opencode|hermes|claude-code|codex|kimi-code|pi) was a strict subset of @tangle-network/sandbox's exported 14-value BackendType and drifted from it. Alias to the SDK type — one source of truth for the harness set, no behavior change (widening only). First step of the A) converge onto the one resolver: every bench backend selector now references the canonical type.
tangletools
approved these changes
Jun 14, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — 33e5ebe2
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-14T14:02:32Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A) converge cleanup — step 1
First, safe step of retiring the non-unified flows onto the one resolver / canonical SDK types.
WorkerBackendTypewas a hand-maintained literal copy (opencode|hermes|claude-code|codex|kimi-code|pi) — a strict subset of@tangle-network/sandbox's exported 14-valueBackendType, drifting from the real harness set. Aliased to the SDK type: one source of truth, no behavior change (widening only). All bench backend selectors (experiment.ts,run.ts,run-benchmarks.ts,search-bench/run.mts) now reference the canonical type.Typecheck clean.
Why this is step 1 of a staged converge (not the whole thing)
The remaining A) items are load-bearing and each is generic-loop + domain-glue, so they need individual tested PRs, not a big-bang into the kernel:
runAgentic'sshotExecutor/agenticRegistry(off-box) → resolve worker fromcreateExecutorRegistry(keep both loop substrates; both resolve from the one registry).benchSolverRegistry(solve+judge leaf) → extract the shared off-box-completion path, keep the judge as a seam.gym-agentoff-box loop → superseded by feat(bench): generalized AgentProfile-coordinate optimizer on the sandbox surface #293's sandbox-surface worker once EOPS gym is box-routable.rsi.tsBACKEND-env → profile-driven harness (needs harness as a first-class profile field).These converge onto #293's
profile-coordinates+ thecreateExecutorRegistryresolver.