chore: drop stale onnxruntime-node CUDA-skip npmrc setting (post-ADR-0019)#254
Merged
Merged
Conversation
…0019) `onnxruntime_node_install_cuda=skip` and its pnpm-workspace.yaml note guarded the onnxruntime-node postinstall (a ~400MB CUDA EP fetch). That package was replaced by onnxruntime-web (prebuilt WASM, no install script) in the single-file SQLite migration (ADR 0019) and is no longer a dependency anywhere — the setting only produced an "Unknown config" warning on every npm/pnpm invocation. Removing both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead
onnxruntime_node_install_cuda=skipconfig from.npmrcand its accompanying note inpnpm-workspace.yaml.That setting guarded the onnxruntime-node postinstall (which otherwise fetched a ~400MB CUDA execution provider from NuGet). onnxruntime-node was replaced by onnxruntime-web (prebuilt WASM, no install script) in the single-file SQLite migration (ADR 0019) and is no longer a dependency anywhere in the workspace.
The leftover setting did nothing except emit
npm warn Unknown ... config "onnxruntime_node_install_cuda"on every npm/pnpm invocation (visible in the v0.10.0 publish logs). No-op cleanup.Verification
grep -rn onnxruntime-node packages/*/package.json package.json→ no matches (not a dependency).