chore(deps): bump nodemailer and @solid/community-server#2
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(deps): bump nodemailer and @solid/community-server#2dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) to 8.0.5 and updates ancestor dependency [@solid/community-server](https://github.com/CommunitySolidServer/CommunitySolidServer). These dependencies need to be updated together. Updates `nodemailer` from 7.0.13 to 8.0.5 - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v7.0.13...v8.0.5) Updates `@solid/community-server` from 7.1.9 to 8.0.0-alpha.3 - [Release notes](https://github.com/CommunitySolidServer/CommunitySolidServer/releases) - [Changelog](https://github.com/CommunitySolidServer/CommunitySolidServer/blob/v8.0.0-alpha.3/CHANGELOG.md) - [Commits](CommunitySolidServer/CommunitySolidServer@v7.1.9...v8.0.0-alpha.3) --- updated-dependencies: - dependency-name: nodemailer dependency-version: 8.0.5 dependency-type: indirect - dependency-name: "@solid/community-server" dependency-version: 8.0.0-alpha.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
jeswr
added a commit
that referenced
this pull request
Jun 21, 2026
…l-open + grant-before-login High #1 (requesting-origin.ts): a PRESENT-but-opaque sender.origin (Chrome stamps the literal string "null" for sandboxed/opaque frames) used to fall back to sender.url, laundering an opaque sender with a normal https url + matching stamp into a TRUSTED origin (opaque-boundary fail-OPEN). Now classifySenderOrigin distinguishes ABSENT (undefined/null/empty → may derive from sender.url) from PRESENT-but-OPAQUE ("null"/unparseable/non-http(s) → DENY immediately, no url fallback). Legit cases preserved: real https sender.origin, absent-origin url fallback, blob:-resolves-to-creator-origin. High #2 (service-worker.ts handleLogin): grantOrigin was called BEFORE initiateLogin, so any page could send SOLID_LOGIN, get its origin persisted as granted even if the auth flow cancelled/failed, then ride an existing session via SOLID_FETCH_REQUEST (privilege escalation). The verified requesting origin is now resolved BEFORE login (to bind the flow) but grantOrigin is moved to the success path — a cancelled/failed login leaves the grant store unchanged. Adversarial tests added (205 total, all green): present-opaque sender.origin denies with no url fallback (pure + wired, no egress); absent-origin url fallback still resolves; failed/cancelled login persists no grant and a subsequent fetch is denied even when a session exists; successful login grants + fetch succeeds; forged login origin not granted even on success. Gate: lint + typecheck + 205 tests + build all green. Model: claude-opus-4-8 Provenance: Opus 4.8 (Fable unavailable) — re-review/upgrade candidate Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeswr
added a commit
that referenced
this pull request
Jun 21, 2026
…-inject, cache best-effort, byte purge, HEAD body roborev (codex) found 5 real issues unit tests missed on feat/phase-1-shared-replica. All fixed, with adversarial tests. High #1 — global-fetch over-divert broke non-pod web traffic. The inject diverted EVERY cross-origin http(s) fetch into the gated path, so an app's calls to third-party APIs/CDNs were DENIED (403) as unauthenticated. Decision (option b — keep the inject DUMB, the SW the boundary): the inject routes everything but marks the request `autoDivert: true`; the SW NATIVE-PASSES-THROUGH (plain unauthenticated fetch, no token, no replica) for any non-ALLOW gate decision instead of a 403, so normal web traffic is never broken and access can never widen (a native fetch carries no credential). The credential/replica path is taken ONLY on an explicit gate ALLOW (known pod origin from a granted requesting origin). An explicit window.solid.fetch (autoDivert false) keeps the 403. Applied at every SW exit: gate deny, forbidden/opaque origin, and no-session. Medium #2 — double injection. inject.js was BOTH manifest-declared and dynamically registered → could run twice and throw on the configurable:false defineProperty. Removed the manifest MAIN-world declaration (dynamic registerContentScripts is now the single path) AND added a `window.__solidInjected`/`'solid' in window` idempotency guard so a double-run is an inert no-op regardless. Medium #3 — a non-cacheable 2xx (206 / Vary:*) broke the request when cache.put rejected. Caching is now best-effort: cache.put + metadata write are wrapped in try/catch, the live response is cloned up-front and returned regardless of persist failure. Medium #4 (privacy) — the null-WebID logout purge cleared metadata but left CacheStorage bytes. Added cache-key enumeration (ReplicaByteCache.keys(), defaulting to cache.keys()); the null purge now deletes all replica byte entries, so bytes + metadata + nonces are all gone on an unknown-prior logout/reset. Low #5 — HEAD returned a body (the cached GET body on a 304, or a pod's stray HEAD body). A HEAD response is now body-stripped on every served path (304 cache hit, live egress) in the replica and in the SW relay. Tests: +23 cases across replica/SW + a new test/inject.test.ts (8 cases, fresh-JSDOM-per- test, no new dep — local test/jsdom.d.ts ambient). Gate green: lint + typecheck + 262 tests + build. Model: claude-opus-4-8 Provenance: Opus 4.8 (Fable unavailable) — re-review/upgrade candidate Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps nodemailer to 8.0.5 and updates ancestor dependency @solid/community-server. These dependencies need to be updated together.
Updates
nodemailerfrom 7.0.13 to 8.0.5Release notes
Sourced from nodemailer's releases.
... (truncated)
Changelog
Sourced from nodemailer's changelog.
... (truncated)
Commits
202cfb3chore(master): release 8.0.5 (#1809)b634abfdocs: add CLAUDE.md with project conventions and release process95876b1fix: decode SMTP server responses as UTF-8 at line boundary0a43876fix: sanitize CRLF in transport name option to prevent SMTP command injection...08e59e6chore: update dev dependencies2d31975chore(master): release 8.0.4 (#1806)2d7b971fix: sanitize envelope size to prevent SMTP command injection4e702e9chore(master): release 8.0.3 (#1804)c803d90fix: remove familySupportCache that broke DNS resolution testse8c8b92fix: fix cookie bugs, remove dead code, and improve hot-path efficiencyUpdates
@solid/community-serverfrom 7.1.9 to 8.0.0-alpha.3Release notes
Sourced from
@solid/community-server's releases.Changelog
Sourced from
@solid/community-server's changelog.... (truncated)
Commits
ab94030chore(release): Release version 8.0.0-alpha.3 of the npm package55a2748chore: Update dependencies38cc0a4chore(release): Release version 8.0.0-alpha.2 of the npm packagee99a919Merge branch 'main' into versions/next-major8575af4fix: Preserve content-type when present in SPARQL accessor802fc8echore(deps): bump n3 from 1.26.0 to 2.0.0675910bchore(deps): bump fetch-sparql-endpoint from 6.2.0 to 7.1.0207bc5cdocs: Mention new contexts in release notes056d866chore(deps): bump marked from 16.3.0 to 17.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.