Migrated to pyproject.toml and uv.lock#39
Open
robin523790 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project from setup.py / requirements.txt to a modern pyproject.toml + uv.lock-based workflow, while raising the minimum supported Python version and updating key dependencies.
Changes:
- Replace legacy packaging/config (
setup.py,requirements.txt,pyrightconfig.json) withpyproject.tomland a committeduv.lock. - Bump required Python to
>=3.10and updatewxPythonrequirement to>=4.2.2. - Remove a set of unused imports across the wx widgets, core, and gallery modules.
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds uv lockfile for reproducible installs (note: contains a marker issue for wxPython→NumPy on Python 3.12+). |
pyproject.toml |
Defines project metadata, dependencies, and tool configs (note: uv workspace member path and Ruff exclude config need adjustment). |
scripts/run-pyright-locally.ps1 |
Adds a local lint/typecheck helper script (note: venv activation path and npm exec invocation need fixes). |
setup.py |
Removed in favor of PEP 621 pyproject.toml. |
requirements.txt |
Removed in favor of pyproject.toml/uv dependency management. |
pyrightconfig.json |
Removed in favor of [tool.pyright] in pyproject.toml. |
construct_editor/wx_widgets/wx_obj_view.py |
Removes an unused import. |
construct_editor/wx_widgets/wx_hex_editor.py |
Removes unused wx imports. |
construct_editor/wx_widgets/wx_construct_editor.py |
Removes unused EntryFlag import. |
construct_editor/core/entries.py |
Removes unused enum import. |
construct_editor/core/construct_editor.py |
Removes unused model import. |
construct_editor/gallery/* |
Removes unused imports in gallery examples/tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bumped minimum Python version to >=3.10 (previously: >=3.8 which reached end-of-life) Bumped wxPython to >=4.2.2 (previously: >=4.1.1 which looks like it was yanked)
timrid
requested changes
Jun 9, 2026
…ill be a separate PR) Re-added `construct` as direct dependencies. Added "optional extra" dependencies to `pyproject.toml`. Added `poethepoet` and `pyright` as dev-dependencies. Added Changelog entry about `version.py` being removed.
Moved "extras" to dev-dependencies, added `cryptography`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to pyproject.toml and uv.lock.
Bumped required Python version to >=3.10 (previously: >=3.8 which has reached end-of-life).
Bumped wxPython to >=4.2.2 (previously: >=4.1.1 which looks like it was yanked).
Removed unused imports.