chore(issues): archive closed issue #1671 spec and update cleanup skill#1929
Merged
josecelano merged 3 commits intoJun 21, 2026
Merged
Conversation
…closed Move the spec for the IPv4/IPv6 client metrics feature from docs/issues/open/ to docs/issues/closed/ after GitHub issue closure. - Update ISSUE.md frontmatter: status: open → done, spec-path → closed path, last-updated-utc → today - Mark workflow checkboxes as complete - Add progress log entry for archival - Add frontmatter to research-dual-stack-portability.md
…h and PR workflow - Archive is the only automated stage; permanent deletion is user-driven - Mandatory branch creation (never commit to develop) - Added step to open a PR targeting develop - Updated workflow checkboxes and progress log guidance - Removed premature stage-2 deletion logic
There was a problem hiding this comment.
Pull request overview
Archives the closed issue #1671 specification into the docs/issues/closed/ buffer and updates the cleanup-completed-issues skill to reflect the current archiving workflow.
Changes:
- Updated issue spec frontmatter/status and workflow checkpoints for closed state.
- Added frontmatter to the #1671 research document in the closed spec folder.
- Revised the cleanup skill to emphasize branch/PR workflow and remove deletion guidance.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/issues/closed/1671-ipv4-ipv6-client-metrics/research-dual-stack-portability.md |
Adds frontmatter metadata to the archived research doc (needs semantic-links to match docs conventions). |
docs/issues/closed/1671-ipv4-ipv6-client-metrics/ISSUE.md |
Marks the issue spec as done and updates spec-path/date + workflow/progress log for archiving. |
.github/skills/dev/planning/cleanup-completed-issues/SKILL.md |
Updates the archiving workflow steps (branching, pre-commit, PR creation) but contains a couple of actionable instruction issues. |
Comments suppressed due to low confidence (1)
docs/issues/closed/1671-ipv4-ipv6-client-metrics/research-dual-stack-portability.md:4
- The new frontmatter block is missing the repo’s standard
semantic-linkssection. Other non-issue Markdown docs underdocs/includesemantic-links(even when they also have other metadata), and the frontmatter guidance indocs/issues/closed/1810-add-frontmatter-to-docs-markdown-files.mdexpects it for general docs. Add a minimalsemantic-linkssection (at least linking back to the parent ISSUE).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+45
to
+47
| git checkout develop | ||
| git pull torrust develop | ||
| git checkout -b chore/cleanup-completed-issues |
| --repo torrust/torrust-tracker \ | ||
| --base develop \ | ||
| --head {your-fork-remote}:chore/cleanup-completed-issues \ | ||
| --title "chore(issues): archive closed issue #{N} spec to docs/issues/closed" \ |
| ## Lifecycle | ||
|
|
||
| Closed issue specs are **not deleted immediately**. They go through a two-stage lifecycle: | ||
| Closed issue specs follow a single automated stage: |
- Use UPSTREAM_REMOTE variable with --ff-only for pull
- Fix PR title template: #${N} instead of #{N}
- Clarify lifecycle wording per review suggestion
- Add semantic-links to research-dual-stack-portability.md
- Add supplementary doc frontmatter guidance to skill
Member
Author
|
ACK 0a07150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archives the spec for issue #1671 (IPv4/IPv6 client metrics) from
docs/issues/open/todocs/issues/closed/.Changes
CLOSEDon GitHub, moved viagit mvstatus: done,spec-path→ closed path,last-updated-utc→ todaycleanup-completed-issues/SKILL.mdv1.3 — clarified branch/PR workflow, removed premature stage-2 deletion logic, added mandatory branch creation step, added PR stepVerification
git mv