fix(codegen): clean up dead code and order-fragile assertion in TRON paths#122
Merged
CodeNinjaEvan merged 1 commit intoJun 25, 2026
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
yanghang8612
changed the title
Remove no-op expression accepts and stale V1-stake member names in legacy; replace the IR bound-first-argument check that depended on FunctionType::Kind ordering.
yanghang8612
force-pushed
the
fix/tron-codegen-cleanup
branch
from
4d9882c to
fa77fc9
Compare
yanghang8612
changed the title
CodeNinjaEvan
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three zero-impact clean-ups in the TRON code paths of the legacy (
ExpressionCompiler) and IR (IRGeneratorForStatements) code generators. None of these change the generated bytecode for any valid input.Changes
addressmember-access read-set still listedtotalFrozenBalance/frozenBalance/frozenBalanceUsage, removed years ago in the V1→V2 stake refactor — unreachable dead code (the IR backend was already clean).expression().accept()(legacy). The zero-argument magic builtinswithdrawreward/cancelAllUnfreezeV2/withdrawExpireUnfreezeeach ran_functionCall.expression().accept(*this), a no-op for a magic variable (cf.gasleft, which does not).!hasBoundFirstArgument()viakind < AvailableUnfreezeV2Size, relying on the declaration order ofFunctionType::Kind. Replaced with an explicit set of the bound (address-member-read) kinds, so reordering the enum can no longer silently invalidate the check.Verification
solcbuilds cleanly;withdrawrewardruntime bytecode is byte-identical before and after (the clean-ups are genuine no-ops);voteand ordinary contracts compile on both the legacy and via-IR pipelines.Targets
release_0.8.28.🤖 Generated with Claude Code