fix(analysis): improve TRON builtin diagnostics, drop dead via-ir branch#125
Merged
CodeNinjaEvan merged 1 commit intoJun 26, 2026
Conversation
Extend the address-payable hint to freeze/unfreeze/delegateResource/ unDelegateResource; mention msg.tokenid/msg.tokenvalue in the payable error; remove the unreachable via-ir OR term in CommandLineParser.
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
CodeNinjaEvan
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two diagnostic improvements for TRON builtins and one dead-code removal in the analysis / CLI layer. No change to the generated bytecode.
Changes
address payablehint covers all payable-only TRON members (TypeChecker). The 9862 "only available for objects of type address payable" hint listed onlysend/transfer/transferToken, butfreeze/unfreeze/delegateResource/unDelegateResourceare payable-only members too. Calling one of them on a plainaddresspreviously fell back to the generic 9582 "member not found"; now it gives the helpful "use address payable" hint.msg.tokenid/msg.tokenvalue(ViewPureChecker).msg.tokenidandmsg.tokenvalueare classified as payable (correctly), but the 5887 error text was hardcoded to"msg.value" and "callvalue()". Readingmsg.tokenidin a non-payable function therefore reported a misleadingmsg.valuemessage; the text now lists the TRON members as well.--via-irbranch (CommandLineParser). After--via-iris unconditionally rejected withsolThrow, the|| m_args.count(g_strViaIR) > 0term in the following assignment is dead. Removed.Verification
addresscallingfreeze(...)now reports error 9862 (the "address payable" hint) instead of the generic 9582.msg.tokenidin a non-payable function reports an error that namesmsg.tokenid/msg.tokenvalue, not justmsg.value.Targets
release_0.8.28.🤖 Generated with Claude Code